Remove SB3 as a necessary module #505
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sdpkjc
reviewed
Mar 20, 2025
araffin
reviewed
Mar 24, 2025
| @@ -204,23 +129,27 @@ class BaseBuffer(ABC): | |||
| :param n_envs: Number of parallel environments | |||
| """ | |||
|
|
|||
| observation_space: spaces.Space | |||
There was a problem hiding this comment.
I think the buffer classes are missing credits to SB3...
There was a problem hiding this comment.
Apologies, yes, I will add them
vwxyzjn
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SB3 is used for the atari wrappers and buffers. However, this external module makes it more difficult for users to understand implementations (IMHO).
Further, for #502 it is limited by needing SB3 to update to support Gymnasium v1.1, for which this PR removes that problem
Finally, IMO the
ReplayBufferimplementation in particular are inefficient, and could be improved which would be easier once incorporated into this repoTypes of changes
Checklist:
pre-commit run --all-filespasses (required).mkdocs serve.If you need to run benchmark experiments for a performance-impacting changes:
--capture_video.python -m openrlbenchmark.rlops.python -m openrlbenchmark.rlopsutility to the documentation.python -m openrlbenchmark.rlops ....your_args... --report, to the documentation.