Skip to content

Allow event blank and fix 500 bug #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonasdeluna
Copy link
Member

@jonasdeluna jonasdeluna commented Apr 17, 2025

Description

Fixes perm checks

Testing

  • The code quality is at a minimum required level of quality, readability, and performance.
  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.

Resolves ABA-1430

Copy link

sentry-io bot commented Apr 17, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: lego/apps/surveys/permissions.py

Function Unhandled Issue
has_perm AttributeError: 'NoneType' object has no attribute 'registrations' /ap...
Event Count: 33

Did you find this useful? React with a 👍 or 👎

Copy link

linear bot commented Apr 17, 2025

Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (82c74d1) to head (f36893a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3832   +/-   ##
=======================================
  Coverage   89.97%   89.97%           
=======================================
  Files         761      762    +1     
  Lines       24364    24370    +6     
=======================================
+ Hits        21921    21927    +6     
  Misses       2443     2443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants