wip: tx spec #10
Closed
wip: tx spec #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gakonst
reviewed
Feb 28, 2024
playground/src/index.tsx
Outdated
| app.route('/todos', todoApp) | ||
| app.route('/routing', routingApp) | ||
|
|
||
| export const erc20Abi = [ |
There was a problem hiding this comment.
we should viemify these, human readable abi etc.
src/components/Button.tsx
Outdated
Comment on lines
134
to
141
| return [ | ||
| <meta | ||
| property={`fc:frame:button:${index}`} | ||
| content={children} | ||
| data-value="_t" | ||
| />, | ||
| <meta property={`fc:frame:button:${index}:action`} content="tx" />, | ||
| <meta property={`fc:frame:button:${index}:target`} content={location} />, | ||
| ] as unknown as HtmlEscapedString |
Comment on lines
+3
to
+14
| export type OneOf< | ||
| union extends object, | ||
| /// | ||
| keys extends KeyofUnion<union> = KeyofUnion<union>, | ||
| > = union extends infer Item | ||
| ? Pretty<Item & { [_K in Exclude<keys, keyof Item>]?: undefined }> | ||
| : never | ||
| type KeyofUnion<type> = type extends type ? keyof type : never | ||
|
|
||
| export type Pretty<type> = { [key in keyof type]: type[key] } & unknown | ||
|
|
||
| export type Widen<type> = |
dalechyn
requested changes
Feb 29, 2024
playground/src/index.tsx
Outdated
Comment on lines
233
to
251
| value: '984316556204476', | ||
| chainId: '10', |
There was a problem hiding this comment.
Shouldn't value be a bigint and chainId a number?
jxom
force-pushed
the
main
branch
2 times, most recently
from
9a05963 to
dd3578f
Compare
tmm
reviewed
Mar 3, 2024
| @@ -119,11 +119,34 @@ export function ButtonReset({ | |||
| ) | |||
| } | |||
|
|
|||
| export type ButtonTransactionProps = ButtonProps & { | |||
| location: string | |||
There was a problem hiding this comment.
Does it make sense to use target instead to keep inline with the spec?
|
Succeeded by #63. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.