Skip to content

frontend: (pyast) Add support for bigint comparison operations in the PyAST frontend #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 11, 2025

Conversation

EdmundGoodman
Copy link
Collaborator

Add support for bigint comparison operations in the PyAST frontend.

@EdmundGoodman EdmundGoodman added the frontend Forcefully embedding xDSL into Python label Apr 7, 2025
@EdmundGoodman EdmundGoodman self-assigned this Apr 7, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.96%. Comparing base (c3a0c0a) to head (a8937c9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xdsl/frontend/pyast/code_generation.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4193   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files         326      326           
  Lines       44466    44476   +10     
  Branches     5481     5483    +2     
=======================================
+ Hits        39559    39569   +10     
+ Misses       3558     3557    -1     
- Partials     1349     1350    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EdmundGoodman EdmundGoodman changed the base branch from main to edmundgoodman/pyast/concrete-types April 9, 2025 12:43
@EdmundGoodman EdmundGoodman changed the base branch from edmundgoodman/pyast/concrete-types to main April 9, 2025 12:44
@superlopuh superlopuh changed the base branch from main to edmundgoodman/pyast/concrete-types April 9, 2025 12:45
@superlopuh superlopuh changed the base branch from edmundgoodman/pyast/concrete-types to main April 9, 2025 12:45
@superlopuh
Copy link
Member

This seems to now have the same changes as the other PR, is that on purpose?

@EdmundGoodman
Copy link
Collaborator Author

This seems to now have the same changes as the other PR, is that on purpose?

Almost all of this PR is changing the type registration, which is now in #4211. When that is merged, this will only have a single change wrt main which is adding comparison support

@EdmundGoodman EdmundGoodman merged commit ece90c0 into main Apr 11, 2025
18 checks passed
@EdmundGoodman EdmundGoodman deleted the edmundgoodman/pyast/comparison branch April 11, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Forcefully embedding xDSL into Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants