Skip to content

CI: (asv) Adopt new asv template to fix build issues from removed setup.py file #4208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

EdmundGoodman
Copy link
Collaborator

#4147 removed the setup.py file. This broke the asv configuration for environment builds.

This PR adopts the most recent ASV quickstart template which describes how to build from pyproject.toml, and uses this to fix asv environment builds.

@EdmundGoodman EdmundGoodman added the CI Continuous Integration label Apr 8, 2025
@EdmundGoodman EdmundGoodman self-assigned this Apr 8, 2025
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (d328e21) to head (ed0ce1a).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4208   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         325      325           
  Lines       44455    44455           
  Branches     5476     5476           
=======================================
  Hits        39540    39540           
  Misses       3567     3567           
  Partials     1348     1348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EdmundGoodman EdmundGoodman merged commit 17e2a25 into main Apr 14, 2025
18 checks passed
@EdmundGoodman EdmundGoodman deleted the edmundgoodman/benchmarks/asv-fix branch April 14, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants