Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Overlay): fix the misleading overlay example #13399

Merged
merged 2 commits into from
Mar 23, 2025

Conversation

pany-ang
Copy link
Contributor

使该示例正确表达:点击嵌入内容不会关闭遮罩层,点击空白区域可以

@pany-ang
Copy link
Contributor Author

pany-ang commented Mar 18, 2025

CI / test (pull_request) 报错似乎有点无厘头,像是 Vitest 抽风,可以尝试重新执行试试。

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (ec5b45b) to head (d68d311).
Report is 61 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13399      +/-   ##
==========================================
+ Coverage   89.60%   89.70%   +0.09%     
==========================================
  Files         257      257              
  Lines        7013     7020       +7     
  Branches     1736     1738       +2     
==========================================
+ Hits         6284     6297      +13     
+ Misses        384      382       -2     
+ Partials      345      341       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chenjiahan chenjiahan changed the title fix(Docs): fix the misleading overlay example docs(Overlay): fix the misleading overlay example Mar 23, 2025
@chenjiahan chenjiahan merged commit d20ee16 into youzan:main Mar 23, 2025
4 checks passed
@chenjiahan
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants