Skip to content

feat: optional file loading and upgrades #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2025
Merged

feat: optional file loading and upgrades #207

merged 2 commits into from
Mar 23, 2025

Conversation

zifeo
Copy link
Owner

@zifeo zifeo commented Mar 23, 2025

No description provided.

@zifeo zifeo requested a review from Copilot March 23, 2025 22:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for optionally allowing missing files when loading configurations and updates several dependency versions and configurations.

  • Introduces a new test to validate the behavior of allow_missing when loading files.
  • Updates the file-loading method in dataconf/main.py to include the allow_missing parameter.
  • Upgrades dependency versions and adjusts configurations in pyproject.toml, .pre-commit-config.yaml, and ruff.toml; also updates an error message in utils.py for consistency.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/test_multi.py Adds tests for file loading with allow_missing behavior
dataconf/main.py Updates the file function signature to support allow_missing
ruff.toml Adjusts ruff configuration to ignore E501, with updated version
pyproject.toml Upgrades dependency versions including pyparsing and testing libraries
.pre-commit-config.yaml Updates pre-commit hooks to use newer versions
dataconf/utils.py Refactors error string quoting in the unexpected keys exception
Comments suppressed due to low confidence (2)

tests/test_multi.py:72

  • [nitpick] The inner dataclass in test_non_existent_file is named 'A', which may shadow an outer 'A'. Consider renaming it for clarity.
@dataclass

dataconf/utils.py:107

  • [nitpick] Consider using a consistent quoting style in error messages to match the rest of the codebase.
f'unexpected key(s) "{', '.join(unexpected_keys)}" detected for type {clazz} at {path}'

@zifeo zifeo merged commit e9c4249 into main Mar 23, 2025
8 checks passed
@zifeo zifeo deleted the upgrades branch March 23, 2025 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant