-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix vtk reader data #1431
base: main
Are you sure you want to change the base?
Bugfix vtk reader data #1431
Conversation
… which are not from sc and not from t8code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the merge conflict
test/t8_gtest_macros.hxx
Outdated
/** | ||
* Package id for the testsuite. Used for attributes. | ||
*/ | ||
static int t8_testsuite_package_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
static int t8_testsuite_package_id; |
we should not define a global variable here.
googletest provides the possibility to construct entities that can be used over multiple test-suites. We could either do that (more work) or set the package ids in the files where we need them.
test/t8_gtest_main.cxx
Outdated
@@ -36,6 +37,8 @@ main (int argc, char **argv) | |||
mpic = sc_MPI_COMM_WORLD; | |||
sc_init (mpic, 1, 1, NULL, SC_LP_PRODUCTION); | |||
t8_init (SC_LP_DEFAULT); | |||
t8_testsuite_package_id = sc_package_register ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package Id should not be defined globally. We could use one per teststuit.
Does this close #340 (it uses a different approach I think, but addresses the problem?) |
9b55ba0
to
7321333
Compare
d917b5f
to
d4454f2
Compare
Describe your changes here:
Fixes a bug in which cmesh attributes of the vtk reader overwrite already existing attributes with the same key and adds assertions to prevent this behavior.
Introduced a package id for the testsuite.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.License
doc/
(or already has one)Tag Label