Skip to content

CLDR-18369 Revise era codes based on March 20 discussion #4519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sffc
Copy link
Member

@sffc sffc commented Mar 21, 2025

CLDR-18369

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@sffc sffc changed the title Revise era codes based on March 20 discussion CLDR-18369 Revise era codes based on March 20 discussion Mar 21, 2025
Comment on lines 4838 to 4839
<era type="0" end="284-08-28" code="??? TODO ???"/>
<era type="1" start="284-08-29" code="am" primary="true"/> <!-- Anno Martyrum -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a suggestion at tc39/proposal-intl-era-monthcode#25 (comment):

the Coptic calendar should have eras BD and AD, not BM and AM

However, it's at least partly at odds with other resources I can find, all of which use "AM" or "A.M.":

I do see references to A.D. (from "anno Diocletiani"), but concrete usage seems rare. I have no opinion on which is more correct here.

Comment on lines 4857 to 4858
<era type="0" end="8-08-28" code="aa" aliases="mundi"/> <!-- Amete Alem -->
<era type="1" start="8-08-29" code="am" aliases="incar" primary="true"/> <!-- Amete Mihret -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider removing the aliases, they're our invention afaict

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our invention or not, if an ID has been in any release, it needs to be deprecated but maintained as an alias.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory yes, but if neither ICU, nor ICU4X, nor Temporal, nor any implementation we know of has used these, can we be a bit flexible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to discuss this question in the CLDR Design WG meeting. As a general principle I agree with @macchiati, but I don't have evidence that these codes are used anywhere, so I might prefer making an exception in this one case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have evidence that these codes are used anywhere, so I might prefer making an exception in this one case.

Well, it is really the opposite question. Unless we have proof they are they are not used anywhere I think we should keep the old codes as aliases. We do not necessarily know who all of the clients of CLDR data are and how they use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this in the 2025-03-31 CLDR Design WG meeting and the conclusion from that meeting (based on the people who happened to be in attendance that day) was that given how news these codes are, and given that ICU does not use them, and Temporal doesn't use them yet, and that they were added for Temporal, they are new enough that we can just drop the codes currently in the XML.

But I do not want to block this PR on that discussion so if adding the existing codes as aliases is going to move this forward, I'll do that

</eras>
</calendar>
<calendar type="roc">
<eras>
<era type="0" end="1911-12-31" code="roc-inverse" aliases="before-roc"/>
<era type="1" start="1912-01-01" code="roc" aliases="minguo"/>
<era type="0" end="1911-12-31" code="minguo-qian" aliases="broc before-roc"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<era type="0" end="1911-12-31" code="minguo-qian" aliases="broc before-roc"/>
<era type="0" end="1911-12-31" code="minguo-qian"/>

</eras>
</calendar>
<calendar type="ethiopic">
<calendarSystem type="other"/>
<eras>
<era type="0" end="8-08-28" code="ethioaa" aliases="ethiopic-amete-alem mundi"/>
<era type="1" start="8-08-29" code="ethiopic" aliases="incar"/>
<era type="0" end="8-08-28" code="aa" aliases="mundi"/> <!-- Amete Alem -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<era type="0" end="8-08-28" code="aa" aliases="mundi"/> <!-- Amete Alem -->
<era type="0" start="-5492-08-29" code="aa" aliases="mundi"/> <!-- Amete Alem -->

@sffc
Copy link
Member Author

sffc commented Mar 29, 2025

@macchiati any comments on this before you disappear on vacation? (I see you already left one regarding ID stability)

</eras>
</calendar>
<calendar type="indian">
<eras>
<era type="0" start="79-01-01" code="indian" aliases="saka"/>
<era type="0" start="79-01-01" code="saka"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that we cannot use the correct spelling "Śaka", maybe this should be "shaka".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<era type="0" end="1911-12-31" code="roc-inverse" aliases="before-roc"/>
<era type="1" start="1912-01-01" code="roc" aliases="minguo"/>
<era type="0" end="1911-12-31" code="minguo-qian" aliases="broc before-roc"/>
<era type="1" start="1912-01-01" code="minguo" primary="true"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this page https://en.wikipedia.org/wiki/Chinese_calendar_correspondence_table uses "AM", presumably that means "Anno Minguoae" (pardon my Latin).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants